Skip to content

Commit

Permalink
Set video encoder default to x264 and audio to aac (#447)
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisbenincasa authored May 22, 2024
1 parent 47dd62c commit 9313cdd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions types/src/schemas/settingsSchemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const FfmpegSettingsSchema = z.object({
// DEPRECATED
enableTranscoding: z.boolean().default(true),
audioVolumePercent: z.number().default(100),
videoEncoder: z.string().default('mpeg2video'),
audioEncoder: z.string().default('ac3'),
videoEncoder: z.string().default('libx264'),
audioEncoder: z.string().default('aac'),
targetResolution: ResolutionSchema.default({ widthPx: 1920, heightPx: 1080 }),
videoBitrate: z.number().default(2000),
videoBufferSize: z.number().default(2000),
Expand Down
16 changes: 8 additions & 8 deletions web/src/pages/settings/FfmpegSettingsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,17 +205,17 @@ export default function FfmpegSettingsPage() {
h264 with Intel Quick Sync: h264_qsv
MPEG2 with Intel Quick Sync: mpeg2_qsv
NVIDIA: h264_nvenc
MPEG2: mpeg2video (default)
H264: libx264
MPEG2: mpeg2video
H264: libx264 (default)
MacOS: h264_videotoolbox"
>
<IconButton
aria-label="Some possible values are:
h264 with Intel Quick Sync: h264_qsv
MPEG2 with Intel Quick Sync: mpeg2_qsv
NVIDIA: h264_nvenc
MPEG2: mpeg2video (default)
H264: libx264
MPEG2: mpeg2video
H264: libx264 (default)
MacOS: h264_videotoolbox"
edge="end"
>
Expand Down Expand Up @@ -438,15 +438,15 @@ export default function FfmpegSettingsPage() {
<InputAdornment position="end">
<Tooltip
title="Some possible values are:
aac
ac3 (default), ac3_fixed
aac (default)
ac3, ac3_fixed
flac
libmp3lame"
>
<IconButton
aria-label="Some possible values are:
aac
ac3 (default), ac3_fixed
aac (default)
ac3, ac3_fixed
flac
libmp3lame"
edge="end"
Expand Down

0 comments on commit 9313cdd

Please sign in to comment.