-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Umami Analytics #34
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request updates the analytics implementation by replacing Digistats with Umami Analytics. It also adds event tracking for various user interactions throughout the application. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chraebsli - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of the Content Security Policy in vercel.json could pose security risks. Consider updating the CSP to accommodate the new analytics implementation instead of removing it entirely.
- In the umamiTrack function, consider defining a more specific type for the options parameter instead of using 'any' for better type safety.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
Fix the Umami Analytics integration by updating the script URL and configuration, and enhance user interaction tracking across multiple components using a new umamiTrack utility function.
Bug Fixes:
Enhancements:
Chores: