Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scalar floor and refactor temperature and density floors #363

Merged
merged 59 commits into from
Feb 1, 2024
Merged

Add scalar floor and refactor temperature and density floors #363

merged 59 commits into from
Feb 1, 2024

Commits on Apr 28, 2023

  1. add function to apply a floor to any conserved variable and apply a d… 

    …ust density floor
    @helenarichie
    helenarichie committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    3ecb87d View commit details
    Browse the repository at this point in the history

  2. remove unnecessary macro

    @helenarichie
    helenarichie committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    3dd1d30 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    198200b View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. save progress

    @helenarichie
    helenarichie committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2a6eb5f View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c793c79 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4fda7e2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    9a245c3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b341db6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8a58a85 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    25832d4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    36a54e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. add test for scalar floor kernel

    @helenarichie
    helenarichie committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    77d6e1a View commit details
    Browse the repository at this point in the history

  2. run clang format

    @helenarichie
    helenarichie committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    639be11 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    25cdde9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. update branch

    @helenarichie
    helenarichie committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0fd7f89 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. update initial conditions

    @helenarichie
    helenarichie committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    098fe22 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. save simulation setup

    @helenarichie
    helenarichie committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9b7e614 View commit details
    Browse the repository at this point in the history

  2. resolve merge conflict

    @helenarichie
    helenarichie committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    fed86f7 View commit details
    Browse the repository at this point in the history

  3. resolve merge conflict

    @helenarichie
    helenarichie committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4077edd View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. update from cell averaging PR

    @helenarichie
    helenarichie committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3cd6b2e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. update branch

    Helena Richie committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c1ccee3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev-scalar-floor

    Helena Richie committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ed40066 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. update build

    Helena Richie committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5b85251 View commit details
    Browse the repository at this point in the history

  2. hard-code cloud temp

    @helenarichie
    helenarichie committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f5dc360 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    60b51a5 View commit details
    Browse the repository at this point in the history

  4. update build

    @helenarichie
    helenarichie committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e12b846 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. update build

    @helenarichie
    helenarichie committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    3fec978 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. clean up initial conditions

    @helenarichie
    helenarichie committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    328770b View commit details
    Browse the repository at this point in the history

  2. reset to default settings

    @helenarichie
    helenarichie committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    2f3ef5f View commit details
    Browse the repository at this point in the history

  3. get floor values from paramter file and remove density floor kernel

    @helenarichie
    helenarichie committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    094f1e9 View commit details
    Browse the repository at this point in the history

  4. run clang format

    @helenarichie
    helenarichie committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d783bb7 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. remove reference to DENS_FLOOR macro

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    399921b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    fa7cfba View commit details
    Browse the repository at this point in the history

  3. run clang format

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f276258 View commit details
    Browse the repository at this point in the history

  4. run clang format

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    37ccafd View commit details
    Browse the repository at this point in the history

  5. run clang format

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d737c4b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5f46029 View commit details
    Browse the repository at this point in the history

  7. undo accidental change

    @helenarichie
    helenarichie authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d292c46 View commit details
    Browse the repository at this point in the history

  8. undo accidental removal of density floor in half-step

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    da2d264 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev-scalar-floor' of github.com:helenarichie/cholla int… 

    …o dev-scalar-floor
    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8945bd4 View commit details
    Browse the repository at this point in the history

  10. fix undeclared variable

    @helenarichie
    helenarichie committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ef47030 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. remove debugging print statement

    @helenarichie
    helenarichie committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2a5d7ed View commit details
    Browse the repository at this point in the history

  2. add host wrapper functions for temp and scalar floor kernels and move… 

    … calls to grid3d::update_hydro_grid
    @helenarichie
    helenarichie committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    db0f788 View commit details
    Browse the repository at this point in the history

  3. run clang format'

    @helenarichie
    helenarichie committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    71df115 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cfd9c0b View commit details
    Browse the repository at this point in the history

  2. run clang format

    @helenarichie
    helenarichie committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cb5e8f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Update hydro build to use VL and PLMC 

    Updated the default hydro build to use the Van Leer (VL) and PLMC build
options. Also, updated the test data for those new builds
    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ddbd312 View commit details
    Browse the repository at this point in the history

  2. Switch MHD to using PLMC by default 

    Also updated test data
    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    29aa051 View commit details
    Browse the repository at this point in the history

  3. Update other builds to PLMC and VL default 

    Updated template, basic_scalar, disk, dust, rot_proj, static_grav to
use PLMC and Van Leer integrator
    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fafcf4f View commit details
    Browse the repository at this point in the history

  4. Make sure cosmology builds use SIMPLE integrator

    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    2215b2f View commit details
    Browse the repository at this point in the history

  5. Fix clang-tidy warning

    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ff09d5d View commit details
    Browse the repository at this point in the history

  6. Replace #warning with print to cerr 

    Avoids issues with running clang-tidy in non-VL builds
    @bcaddy @helenarichie
    bcaddy authored and helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b458962 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    35e327a View commit details
    Browse the repository at this point in the history

  8. set default floor values in global.h and add warning

    @helenarichie
    helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3e1c195 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8e2c742 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into dev-scalar-floor

    @helenarichie
    helenarichie authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8610f35 View commit details
    Browse the repository at this point in the history

  11. change warning message and tweak how the default floors are set

    @helenarichie
    helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    114f96b View commit details
    Browse the repository at this point in the history

  12. fix syntax errors

    @helenarichie
    helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3eb2fb8 View commit details
    Browse the repository at this point in the history

  13. run clang format

    @helenarichie
    helenarichie committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    cede7f3 View commit details
    Browse the repository at this point in the history