Test new open ffmast fix #1237
Open
Test new open ffmast fix #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I'll make the changes in this branch/PR such that we run the tests that were failing with Openmm8. Thanks! |
|
Do we want to merge this in so we can keep these tests running? Part of me is thinking that it could be good to keep these tests running, even if it is using an unreleased beta of the openeye-toolkit. |
|
I think it could be worth it to have this in a separate flow (yet another one haha). Is that a reasonable way to do it? |
|
We could add it to the matrix (but just do it for one python version and on linux). I am trying to think of the risks of just keeping it as is. |
|
I don't see any immediate risks with this. I agree with adding it to the matrix (single python+linux). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ijpulidos do you remember which test(s) we disabled because of this bug?