List of input smiles as input for RelativeFEPSetup
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the
RelativeFEPSetupto accept a list of smiles as input.It does it by trying to read the input parameter as smiles using the
openff.toolkit.Moleculeobject and if it fails with a specific exception it assumes it is then a list of path to sdf/mol2 files.Motivation and context
Resolves #1155
How has this been tested?
Test is failing with the following error
I think there is some information getting mixed up or lost when we do the trip from
openff.toolkit.MoleculetoOEMolusing the.to_openeye()method from openff.Change log