add ANI2x test against original implementation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR adds a test that uses the original ANI2x parameters and checks if the modelforge implementation returns the same output.
There is also one additional change to deciding if the pairlist should contain unique or all interactions: this was done previously by passing a control parameter to the PotentialFactory class. This PR changes this and makes this decision based on the potential name. This is much more robust in my opinion (Note: the ANI architecture returns the same output whether unique or all pairs are passed, so that is not a big issue).
Key changes
Pull Request Checklist