Skip to content

Commit

Permalink
Addressing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisiacovella committed Aug 27, 2024
1 parent e360882 commit d93c82f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
8 changes: 0 additions & 8 deletions modelforge/potential/ani.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@
from modelforge.utils.prop import SpeciesAEV


# if TYPE_CHECKING:
# from modelforge.dataset.dataset import NNPInput
# from .models import PairListOutputs


def triu_index(num_species: int) -> torch.Tensor:
"""
Generate a tensor representing the upper triangular indices for species pairs.
Expand Down Expand Up @@ -110,7 +105,6 @@ def __init__(
angle_sections: int,
nr_of_supported_elements: int = 7,
):

super().__init__()
from modelforge.potential.utils import CosineAttenuationFunction

Expand Down Expand Up @@ -386,7 +380,6 @@ class ANIInteraction(nn.Module):
"""

def __init__(self, *, aev_dim: int, activation_function: Type[torch.nn.Module]):

super().__init__()
# define atomic neural network
atomic_neural_networks = self.intialize_atomic_neural_network(
Expand Down Expand Up @@ -677,7 +670,6 @@ def __init__(
dataset_statistic: Optional[Dict[str, float]] = None,
potential_seed: Optional[int] = None,
) -> None:

from modelforge.utils.units import _convert_str_to_unit

self.only_unique_pairs = True # NOTE: need to be set before super().__init__
Expand Down
6 changes: 0 additions & 6 deletions modelforge/potential/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,6 @@ def forward(
)

return interacting_outputs
#
# return PairListOutputs(
# pair_indices=pair_indices_within_cutoff,
# d_ij=d_ij[in_cutoff],
# r_ij=r_ij[in_cutoff],
# )


from typing import Callable, Literal, Optional, Union
Expand Down

0 comments on commit d93c82f

Please sign in to comment.