Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] test which version of DGL will work #177

Closed
wants to merge 2 commits into from
Closed

[DNM] test which version of DGL will work #177

wants to merge 2 commits into from

Conversation

mikemhenry
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7165038). Click here to learn what that means.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

It looks like we need to use 0.9.0 only because it looks like dglteam builds their dgl.sparse package (which is new) against pytorch from defaults so when we install pytorch from conda-forge we get an error. The older dgl packages don't do this, which is why they work. Our dgl package that we are getting onto conda-forge builds/links against the correct packages, so while it looks like newer dgl versions don't work, they should!

@mikemhenry
Copy link
Contributor Author

Looks like dgl<1 is what we want

@mikemhenry mikemhenry closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemhenry @codecov-commenter