Add icons customizability for modularity #420
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the icons template into self-contained blocks
Pull Request type
Please check the type of change your PR introduces:
Current state
Currently, all clarity users are forced to load ~ dozen social icons which they very well may not need on their websites. This situation makes the html size of their pages unnecessarily bloated.
I have been reluctant merging PRs for icons. However, after merging #404, I realized that we could actually modularize things so that users can add icons freely while avoiding the aforementioned problem.
This represents a breaking change for existing theme users. To update, they will need add to
config/_default/params.toml
a generic listicons
.Issue Number(s):
Proposed changes
Screenshots, if applicable
Checklist
git commit -s ...
), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.