-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VSCode command of generating verible.filelist at the root folder #2277
base: master
Are you sure you want to change the base?
Conversation
mmh, I think instead of adding more complexity to the various editor configuration which makes it fragile and hard-to-maintain, we should have a flag to the verible language server to automatically find the files instead. Can you file an issue with that, essentially pointing out the problem you pose above ? |
That's the truth in constructing clean and pure code infrastructures that provide fundamental functions, i.e. the language server itself. 🐱
That's a awesome solution! But I think filelists are still necessary, as it should be the users' freedom to choose which file is going to be indexed and which is not.
Here is one: #2177 |
I also have issues with I personally would like
I think supporting As an aside, I really like how slang deal with that problem. They make their file be able to specify command line arguments and not just list individual files. They also support listing only directories and include individual files based on parsing and naming convention (for example, a file with |
What's the Problem?
The
verible.filelist
is essential for LSP to function with multiple files, i.e. finding the definition of a module from another source.However, it's not documented in the VSCode Extension README and neither does a command exist for generating the filelist, which may cause confusion for users who is not quite familiar with the
Verible
toolkit.What has been done in this PR?
.v
,.sv
,.vh
and.svh
are set as default) and generating theverible.filelist
at the project root, then restarting the language server so that the new filelist can be loaded.Quick Start
section is added to theREADME.md
, helping new users understand how to use the verible language server with VSCode properly.