If non-mmap: use stdio reading of files instead of std::stream #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20241002-no-stream-read
branch
8 times, most recently
from
ad4b4d5
to
04ea51c
Compare
hzeller
force-pushed
the
feature-20241002-no-stream-read
branch
from
04ea51c
to
2626a70
Compare
std::fstream is much slower than the good ol' standard implementation. In addition, there are no risks of throwing exceptions.
hzeller
force-pushed
the
feature-20241002-no-stream-read
branch
from
2626a70
to
13e0cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::fstream is much slower than the good ol' standard implementation. In addition, there are no risks of throwing exceptions.