Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: text: config_utils: make ParseNameValues skip empty strings #2267

Conversation

IEncinas10
Copy link
Collaborator

$ cat .rules.verible_lint
+always-ff-non-blocking=catch_modifying_assignments:on;
$ verible-verilog-lint file.sv --rules_config_search
E0929 18:52:13.789277   24408 verilog_linter.cc:146] Fatal error: always-ff-non-blocking : unknown parameter; supported parameters are 'catch_modifying_assignments', 'waive_for_locals'

Current configuration parsing hard-fails upon encountering trailing or leading semicolons in the configuration string. Let's make the process more robust and ignore them.

Individual rules can be configured using the following schema:
        "<param>:<paramvalue>;<param2>:<value>"
which assumes that there wont be leading or trailing semicolons (;).
Instead of failing, let's make configuration parsing more permissive and
allow them.
@IEncinas10 IEncinas10 force-pushed the make-rule-config-parsing-more-robust branch from 6045049 to 278c546 Compare September 29, 2024 17:14
@hzeller hzeller merged commit 977b5f5 into chipsalliance:master Oct 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants