Initial version of a devcontainer for Verible #2068
+34
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Available versions: https://github.com/devcontainers/images/tree/main/src/cpp | ||
| FROM mcr.microsoft.com/devcontainers/cpp:ubuntu-22.04 | ||
| RUN apt update && apt install -y clang-format clang-tidy | ||
| RUN wget https://github.com/bazelbuild/bazelisk/releases/download/v1.19.0/bazelisk-linux-amd64 -O /usr/local/bin/bazel && chmod a+rx /usr/local/bin/bazel && /usr/local/bin/bazel --version | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node | ||
| { | ||
| "name": "Verible Dev", | ||
| "build": { | ||
| "dockerfile": "Dockerfile", | ||
| // Add any proxy settings if the build of the | ||
|
There was a problem hiding this comment. Please remove commented JSON about proxy settings There was a problem hiding this comment. I've moved the details to the top of the file. Please comment if this meets the crux of your feedback. |
||
| // container is behind a proxy | ||
| // | ||
| // "args" : { | ||
| // "HTTP_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "HTTPS_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "http_proxy": "http://proxy-dmz.intel.com:912/", | ||
| // "https_proxy": "http://proxy-dmz.intel.com:912/" | ||
| // } | ||
| }, | ||
|
|
||
| // Add any proxy settings if connecting to a container on | ||
| // a remote machine | ||
| // | ||
| // "remoteEnv": { | ||
| // "HTTP_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "HTTPS_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "http_proxy": "http://proxy-dmz.intel.com:912/", | ||
| // "https_proxy": "http://proxy-dmz.intel.com:912/", | ||
| // }, | ||
|
|
||
| // Add any proxy settings if the container is behind | ||
| // a proxy | ||
| /// | ||
| // "containerEnv": { | ||
| // "HTTP_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "HTTPS_PROXY": "http://proxy-dmz.intel.com:912/", | ||
| // "http_proxy": "http://proxy-dmz.intel.com:912/", | ||
| // "https_proxy": "http://proxy-dmz.intel.com:912/" | ||
| // }, | ||
|
|
||
| // Configure tool-specific properties. | ||
| "customizations": { | ||
| // Configure properties specific to VS Code. | ||
| "vscode": { | ||
| "settings": {}, | ||
| "extensions": [ | ||
| "ms-vscode.cpptools-extension-pack" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix bazel version to 5.x.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specific code uses bazelisk to install the latest version of bazel. I didn't see the GitHub workflow for the repo doing something to obtain a 5.x.x. version, but may have missed it. Does the workflow do something specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, using a .bazelversion file seems to be the way to go, I'll do that in a separate PR. FYI, the devcontainer will not work today without it since verible is not yet compatible with bazel 7.0.0