Fix mill testing on mill 0.11 and add mill to README and comments #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
approved these changes
Nov 16, 2023
towoe
reviewed
Nov 19, 2023
| @@ -30,7 +30,7 @@ jobs: | |||
| GROUP="com.github.$SAFE_ORG" | |||
|
|
|||
| # Replace placeholders | |||
| sed -i "s/%NAME%/$NAME/g" build.sbt build.sc README.md | |||
| sed -i "s/%NAME%/$NAME/g" build.sbt build.sc README.md src/test/scala/gcd | |||
There was a problem hiding this comment.
@jackkoenig template creation fails for me with "sed: couldn't edit src/test/scala/gcd: not a regular file".
Maybe use 'src/test/scala/gcd/*'?
There was a problem hiding this comment.
Oops, my fault, you are right.
There was a problem hiding this comment.
Good catch, thanks @towoe! I'll push a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mill 0.11 has changed the way to write test module, see https://github.com/com-lihaoyi/mill/releases/tag/0.11.0