Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DPE submodule #1890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update DPE submodule #1890

wants to merge 1 commit into from
+14 −14

Conversation

clundin25
Copy link
Contributor

Adds the following commits:

  • 44a2307 - (HEAD, origin/main, origin/HEAD, main) Update fuzzing toolchain (3 weeks ago)
  • 7b6768d - Fix linter and compiler warnings for rust 1.83 (3 weeks ago)
  • d0d0887 - Update the rust toolchain to 1.83 (3 weeks ago)
  • 6cd2ae8 - Increase max cert size to 6KiB (6 weeks ago)

6cd2ae8 increases the stack usage of DPE. This commit addresses the usage by increasing the stack size of Caliptra.

@clundin25 clundin25 marked this pull request as ready for review January 14, 2025 01:07
@nquarton nquarton linked an issue Jan 14, 2025 that may be closed by this pull request
Caliptra allows enough measurements to be stashed to exceed the 2kB certificate threshold within DPE #1832
Open
nquarton
nquarton approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@nquarton nquarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It doesn't have to necessarily be part of this PR, but we should cover submitting the max number of measurements supported in a test somewhere. I filed an issue for it #1891.

nquarton
nquarton requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nquarton nquarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed we need to update the profile constants in libcaliptra as well

{B73CBD70-4AE8-42F7-9240-F2A529990445}

@clundin25
Copy link
Contributor Author

I just noticed we need to update the profile constants in libcaliptra as well

Thank you! This saved me quite a bit of time debugging!

@clundin25 clundin25 force-pushed the dpe-update branch 2 times, most recently from 31ddabc to d7d919a Compare January 21, 2025 20:43
@clundin25 clundin25 requested a review from nquarton January 21, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquarton nquarton nquarton approved these changes

@jhand2 jhand2 jhand2 approved these changes

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@wmaroneAMD wmaroneAMD Awaiting requested review from wmaroneAMD wmaroneAMD is a code owner

@jlmahowa-amd jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Caliptra v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caliptra allows enough measurements to be stashed to exceed the 2kB certificate threshold within DPE
3 participants
@clundin25 @jhand2 @nquarton