Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to skip clearing SRAM in ROM. #1622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add feature to skip clearing SRAM in ROM. #1622

wants to merge 1 commit into from

Conversation

zhalvorsen
Copy link
Contributor

@zhalvorsen zhalvorsen commented Jul 30, 2024 •
edited
Loading

This allows ROM builds to skip clearing SRAM with the feature skip-clear-sram. This can be useful for simulation builds where clearing SRAM takes a significant amount of time.

korran
korran reviewed Jul 30, 2024
View reviewed changes
rom/dev/src/start.S Outdated Show resolved Hide resolved
@zhalvorsen zhalvorsen mentioned this pull request Jul 30, 2024
Open
@zhalvorsen zhalvorsen force-pushed the zhalvorsen-skip-clearing-sram branch 2 times, most recently from 3a4cf9e to 6faf923 Compare October 21, 2024 23:37
@zhalvorsen zhalvorsen changed the title Remove clearing SRAM by default. Add feature to skip clearing SRAM by default. Oct 21, 2024
@zhalvorsen zhalvorsen changed the title Add feature to skip clearing SRAM by default. Add feature to skip clearing SRAM in ROM. Oct 21, 2024
@zhalvorsen
Add feature to skip clearing SRAM in ROM.
fbf1f40 
This allows ROM builds to skip clearing SRAM with the feature `skip-clear-sram`. This can be useful for simulation builds where clearing SRAM takes a significant amount of time.
@zhalvorsen zhalvorsen force-pushed the zhalvorsen-skip-clearing-sram branch from 6faf923 to fbf1f40 Compare October 21, 2024 23:42
@zhalvorsen zhalvorsen marked this pull request as ready for review October 22, 2024 00:44
@zhalvorsen zhalvorsen requested a review from jhand2 October 22, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korran korran korran left review comments

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@jhand2 jhand2 Awaiting requested review from jhand2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhalvorsen @korran