Refactor/#195 collapse standups #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… panel Modify to collapse the list of all standups down to a single summary panel and detail panel. - Work remains to add the list of all standups to the summary panel and to refresh the detail panel from it. Resolves: N/a See also: #195
Modify layout to match mockup from UI/UX Designer - Reduce font size to 12px - Mixed case labels - Re-add section header Resolves: N/a See also: #195
Update CSS with layout modifications require for collapsing standups to a single card Resolves: N/a See also: #195
Change background color of standup summary and detail panels to white Resolves: N/a See also: #195
Convert `NewsfeedStandup` to be a statful component in preparation for refreshing the standup detail panel based on the selection in the standup summary panel. Resolves: N/a See also: #195
Add state to `newsfeedStandup` to maintain selected standup Resolves: N/a See also: #195
…d standup in state Update `NewsFeedStandup` to hold standups array and selected standup in state Resolves: N/a See also: #195
…fragment generated by `StandupDetail` Remove unnecessary `console.log` statements and add key to fragment generated by `StandupDetail` Resolves: N/a See also: #195
Add recent standup to Summary panel and adjust Summary layout Resolves: N/a See also: #195
…anel Add all, pending, and count of missed standups to Summary panel - Set summary data value color to `$health-green` - Add clickable most recent and list of all completed standups - Add list of pending standups - Add count of missed standups - Remaining work is to allow standup entry when pending standup is clicked Resolves: N/a See also: #195
Update to only display most recent pending standup. Also remove count of missed standups. Resolves: N/a See also: #195
Add edge cases to the standup summary panel and orginize the logic to improve readability and SRP. Resolves: N/a See also: #195
…ank"` Remediate security risk by adding `rel="noopener noreferrer"` to anchor tags with `target="_blank"` Resolves: #192 See also: N/a
Convert class methods to arrow syntax Resolves: N/a See also: #195
Add the `SummaryList` component in preparation for rendering all standup lists from a single component and implementing a `More...` option for multientry lists of standups. See `TODO` flags in code. Resolves: N/a See also: N/a
…f standups Move standup rendering logic to StandupList for all types of standups Resolves: N/a See also: N/a
…ntents Add More/Less anchor tag to change the number of completed standups displayed Resolves: N/a See also: #195
Remove unnecessary comment Resolves: N/a See also: N/a
… sections Add check for no standup to Pending and Most Recent Standup sections Resolves: N/a See also: #195-collapse-standups
Split `SummaryList` component into list-specific components to simplify the code. Using a single component initially seemed like a good idea, but it required conditionals that made the logic difficult to follow. Resolves: N/a See also: #195
… name clicked Add logic to display standup entry form when pending standup name is clicked Also changed anchor tag in `StandupRecent` component to eliminate `href` linter message. Resolves: #195 See also: N/a
Replace hardcodd display count limit with constant Remove border from recent standup button Resolves: #195 See also: N/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: This PR collapse standup history in the newsfeed to a single page displaying only the most recently completed or user selected standup.
Screenshot:
Special Considerations: This matches the mockup created by @serpient with the exception that the heading bar still displays 'nn Days Ago' instead of an absolute date. This is because the heading is a shared component and will need to be updated later.
Feedback: In addition to reviewing the correctness of this change I want to ensure that it accurately implements @serpient's mockup, and that I've followed team standards and best practices.