Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/auth architecture pt2 #277

Open
wants to merge 11 commits into
base: v0.2.0
Choose a base branch
from

Conversation

Dan-Y-Ko
Copy link
Collaborator

Description

Added the logout functionality to the modules folder

Expected behavior: Clicking on sign out in the drop down will redirect user to the sign in page and also clear cookies in the browser

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:10am

async function handleClick() {
const [res, error] = await serverSignOut();
const authAdapter = resolve<AuthClientAdapter>(TYPES.AuthClientAdapter);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this is not the proper way to use the classes inside the components, but if this is working now I will fix it in my next task

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'd like to see what suggestion you have. Do you want to go ahead and merge this for now? This is how I did it with the login (which has been merged already)

Copy link
Collaborator Author

@Dan-Y-Ko Dan-Y-Ko Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd rather wait, then just do your fix in the sign in page (I forget the exact filename), and submit the pr with the suggested change (along with the other tasks) and then we can revisit this one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is straightforward and is related to the task on ClickUp. If you agree, I prefer to merge this pr and then do the fix. If things work I would like to complete the migration server >>> client components and then do the task on ClickUp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants