Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save files downloaded from s3 #130

Open
wants to merge 9 commits into
base: github-action
Choose a base branch
from

Conversation

KyleDolezal
Copy link
Collaborator

Save the files that are downloaded from S3 so they are accessible when running the frontend project in a browser.

Copy link
Collaborator

@dcjohnson24 dcjohnson24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this. I just had a question about changing the target branch to main.

file-path: schedule_vs_realtime_all_day_types_routes.json
- uses: oleksiyrudenko/gha-git-credentials@v2-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this generates a warning about updating to Node 20. I don't know if there is a later version for this action, but maybe line 15 could be changed to actions/checkout@v4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcjohnson24 I have upgraded checkout to version 4, but I am still getting a warning for gha-git-credentials. Unfortunately, there is not a newer version of this action. I can make a PR to that repo, but in the meantime I suggest living with the warning in our repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcjohnson24 I made a PR in the github action to upgrade to version 20 here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this and submitting the PR. I agree that we can live with the warning.

.github/workflows/download-data.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants