-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save files downloaded from s3 #130
base: github-action
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this. I just had a question about changing the target branch to main
.
file-path: schedule_vs_realtime_all_day_types_routes.json | ||
- uses: oleksiyrudenko/gha-git-credentials@v2-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this generates a warning about updating to Node 20. I don't know if there is a later version for this action, but maybe line 15 could be changed to actions/checkout@v4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcjohnson24 I have upgraded checkout to version 4, but I am still getting a warning for gha-git-credentials
. Unfortunately, there is not a newer version of this action. I can make a PR to that repo, but in the meantime I suggest living with the warning in our repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcjohnson24 I made a PR in the github action to upgrade to version 20 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this and submitting the PR. I agree that we can live with the warning.
…uses-frontend into save-ridership-file Add the file committed by GitHub action.
756ce09
to
c0f3a1f
Compare
Save ridership file
Save the files that are downloaded from S3 so they are accessible when running the frontend project in a browser.