Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(101) unify the display of the bus summary stats that appear in th… #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertmiddlekauff
Copy link

@robertmiddlekauff robertmiddlekauff commented Dec 28, 2023

unify the display of the bus summary stats that appear in the modal and on the route-stats page; clean up some console errors; formatting fixes

Description

This PR does the following:

  • fixes issue 101: Bus Route Stats and Modal have different CSS used to create similar appearances  #101
  • some formatting fixes from running prettier on a few files (didn't touch many of those lines of code
  • fixed some console errors from using class instead of classname and from not having a key on dom elements that were mapped over
  • converted some of the styling to use flex mostly bc I think it's easier to use
  • unified the styling of the modal and the route-stats page. I think the modal layout looks good on the route-stats page so I made them the same

Checklist

  • I am requesting to merge into the dev branch
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

| Before | After |
| -------
---- | ----------- |
| Screenshot 2023-12-28 at 5 54 03 PM |
Screenshot 2023-12-28 at 5 53 36 PM
|
|
Screenshot 2023-12-28 at 5 54 52 PM
|
Screenshot 2023-12-28 at 5 53 36 PM
|

…e modal and on the route-stats page; clean up some console errors; formatting fixes
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for creative-quokka-61f1f5 ready!

Name Link
🔨 Latest commit b5017da
🔍 Latest deploy log https://app.netlify.com/sites/creative-quokka-61f1f5/deploys/658e0b4203883200082efab4
😎 Deploy Preview https://deploy-preview-122--creative-quokka-61f1f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for sprightly-muffin-751ffc ready!

Name Link
🔨 Latest commit b5017da
🔍 Latest deploy log https://app.netlify.com/sites/sprightly-muffin-751ffc/deploys/658e0b42ed4f110008f9c27e
😎 Deploy Preview https://deploy-preview-122--sprightly-muffin-751ffc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@KyleDolezal KyleDolezal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only minor quibble is that the styling changes result in a permanent outline around the x button on route info modals when running in Firefox.

Screenshot from 2024-01-06 03-12-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants