Make sure connectPeer rejects when peer is not available
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
commented
May 26, 2024
louwers
changed the title
connectPeer resolves when peer is not availableconnectPeer fulfills when peer is not available
louwers
changed the title
connectPeer fulfills when peer is not availableconnectPeer rejects when peer is not available
|
Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectPeerwill never be fulfilled if the peer does not respond. This is because the error is sent to the peer, not to the connection. This PR fixes that. Extracting the peer from the message is not the most elegant solution, but there's no more reliable way to extract the peer id. If this check is removed the Promise can be rejected in response to the connection to another peer failing.I updated peerjs because the PeerError class is new in 1.5.0.
See also peers/peerjs#1281