Added a column for renewals count to the activity report #1809
+254
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crismali
force-pushed
the
michael-1653-activity-report-improvements
branch
from
f0fd7cc to
f88a3a8
Compare
crismali
force-pushed
the
michael-1653-activity-report-improvements
branch
from
f88a3a8 to
e65f5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This adds a renewals column to the activities report and breaks the report into different tables by year.
Why it is important
#1653
UI Change Screenshot
Implementation notes
The number of renewals for the month is the number of loans created with an
initial_loan_id. Do this mean this number should be removed from the total number of loans?