Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cleanup junk code created by GOB #214

Merged
merged 4 commits into from
Jul 21, 2024
Merged

refactor: Cleanup junk code created by GOB #214

merged 4 commits into from
Jul 21, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Jul 21, 2024

No description provided.

@kanru kanru added this to the 2.1.0 milestone Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 324 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (0ed8594) to head (468abbb).

Files Patch % Lines
src/ibus-chewing-engine.c 45.49% 272 Missing ⚠️
src/IBusChewingPreEdit.c 40.24% 49 Missing ⚠️
src/main.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   60.05%   54.37%   -5.68%     
==========================================
  Files          24       17       -7     
  Lines        2774     2067     -707     
==========================================
- Hits         1666     1124     -542     
+ Misses       1108      943     -165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru force-pushed the refactor-settings branch from f8418d0 to 468abbb Compare July 21, 2024 13:14
@kanru kanru merged commit b56419c into master Jul 21, 2024
3 of 5 checks passed
@kanru kanru deleted the refactor-settings branch July 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant