Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GTK4 and drop X11 dependency #172

Merged
merged 24 commits into from
Feb 6, 2024
Merged

Update to GTK4 and drop X11 dependency #172

merged 24 commits into from
Feb 6, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Feb 3, 2024

No description provided.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (1de53bf) 39.01% compared to head (cc774e7) 59.80%.

❗ Current head cc774e7 differs from pull request most recent head 712697a. Consider uploading reports for the commit 712697a to get more accurate results

Files Patch % Lines
src/ibus-chewing-engine.c 60.50% 124 Missing ⚠️
src/MakerDialogProperty.c 0.00% 6 Missing ⚠️
src/setup/ibus-setup-chewing-window.c 94.79% 5 Missing ⚠️
src/setup/main.c 89.28% 3 Missing ⚠️
src/IBusChewingPreEdit-private.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
+ Coverage   39.01%   59.80%   +20.78%     
===========================================
  Files          30       23        -7     
  Lines        3752     2602     -1150     
===========================================
+ Hits         1464     1556       +92     
+ Misses       2288     1046     -1242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru force-pushed the modernize-2 branch 4 times, most recently from 7802aa2 to 88102d0 Compare February 5, 2024 09:47
@kanru kanru marked this pull request as ready for review February 5, 2024 13:41
@kanru
Copy link
Member Author

kanru commented Feb 5, 2024

There's one remaining issue: Shift + key somehow does not produce a upper case letter in English mode.

src/ibus-chewing-engine.c Outdated Show resolved Hide resolved
src/ibus-chewing-engine.c Outdated Show resolved Hide resolved
src/ibus-chewing-engine.c Outdated Show resolved Hide resolved
src/ibus-chewing-engine.c Show resolved Hide resolved
src/ibus-chewing-engine.c Outdated Show resolved Hide resolved
@kanru kanru merged commit 50d4abb into master Feb 6, 2024
3 checks passed
@kanru kanru added this to the 2.0.0 milestone Feb 6, 2024
@yan12125
Copy link

yan12125 commented Feb 6, 2024

Is it intended to remove many icons? I tried current git-master (4f8f25c) and found icons are missing in several places.

@kanru
Copy link
Member Author

kanru commented Feb 6, 2024

Is it intended to remove many icons? I tried current git-master (4f8f25c) and found icons are missing in several places.

你是說 systray icon 嗎?那應該是唯一會用到 icon 的地方

@kanru
Copy link
Member Author

kanru commented Feb 6, 2024

Is it intended to remove many icons? I tried current git-master (4f8f25c) and found icons are missing in several places.

你是說 systray icon 嗎?那應該是唯一會用到 icon 的地方

Desktop file 的 icon 我有留下來,另外我也有計畫把 systray 加回來,畢竟有些 DE 沒有直接的 ibus integration

@kanru kanru mentioned this pull request Feb 6, 2024
@yan12125
Copy link

yan12125 commented Feb 7, 2024

Is it intended to remove many icons? I tried current git-master (4f8f25c) and found icons are missing in several places.

你是說 systray icon 嗎?那應該是唯一會用到 icon 的地方

「IBus 偏好設定」中的icon也不見了,我提了一個新 issue: #181

@kanru kanru deleted the modernize-2 branch February 10, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants