remove an unnecessary shared_lock in a hot path(every request will co…

…nduct this unnecessary lock) (OpenAtomFoundation#2773)

Co-authored-by: cheniujh <[email protected]>

include/pika_binlog.h

@@ -52,7 +52,7 @@ class Binlog : public pstd::noncopyable {
  void Unlock() { mutex_.unlock(); }
 
  pstd::Status Put(const std::string& item);
-
+ pstd::Status IsOpened();
  pstd::Status GetProducerStatus(uint32_t* filenum, uint64_t* pro_offset, uint32_t* term = nullptr, uint64_t* logic_id = nullptr);
  /*
  * Set Producer pro_num and pro_offset with lock

src/pika_binlog.cc

@@ -145,6 +145,13 @@ void Binlog::InitLogFile() {
  opened_.store(true);
 }
 
+Status Binlog::IsOpened() {
+ if (!opened_.load()) {
+ return Status::Busy("Binlog is not open yet");
+ }
+ return Status::OK();
+}
+
 Status Binlog::GetProducerStatus(uint32_t* filenum, uint64_t* pro_offset, uint32_t* term, uint64_t* logic_id) {
  if (!opened_.load()) {
  return Status::Busy("Binlog is not open yet");

src/pika_consensus.cc

@@ -374,9 +374,7 @@ Status ConsensusCoordinator::InternalAppendBinlog(const std::shared_ptr<Cmd>& cm
  }
  return s;
  }
- uint32_t filenum = 0;
- uint64_t offset = 0;
- return stable_logger_->Logger()->GetProducerStatus(&filenum, &offset);
+ return stable_logger_->Logger()->IsOpened();
 }
 
 Status ConsensusCoordinator::AddSlaveNode(const std::string& ip, int port, int session_id) {