Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom validation messages without pattern #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow custom validation messages without pattern #10

wants to merge 1 commit into from

Conversation

davemo
Copy link

@davemo davemo commented Sep 17, 2015

  • I wanted to be able to allow custom validation messages but not have to rely on client-side i18n and the use of the pattern attribute.
  • I’ve got a failing test here because I’m not super familiar with how your testing setup is expected to work, I was hoping to be able to verify the arguments of the Validity constructor, but it's private. I'm including the test in the hopes it reveals enough intent that you can help me out a bit with how to get this test passing, the code changes as they are work for this feature :)

- I wanted to be able to allow custom validation messages but not have
to rely on client-side i18n and the use of the `pattern` attribute; this
commit allows that
@chemerisuk
Copy link
Owner

@davemo the standard says that title is respected only if the pattern attribute exists. We should think twise when trying to tweak the standard. Could you explain your use case in more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants