Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Check updated signing method for msi #245

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Check updated signing method for msi #245

wants to merge 4 commits into from

Conversation

ahasunos
Copy link
Collaborator

Description

This PR attempts at checking the updated signing method with the new cli introduced in the ss/update-signing-cli-tool branch of omnibus repo.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ahasunos ahasunos requested review from a team as code owners September 13, 2023 14:19
@ahasunos ahasunos force-pushed the ss/update-signing-method-for-msi branch from 88ac877 to 731b750 Compare September 13, 2023 16:12
@ahasunos ahasunos changed the title [WIP] Check updated signing method for msi [DO NOT MERGE] Check updated signing method for msi Sep 14, 2023
@ahasunos
Copy link
Collaborator Author

Duplicates PR: #246

@ahasunos ahasunos closed this Sep 26, 2023
@ahasunos ahasunos reopened this Sep 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahasunos