Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the settings screen #595

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nikhil2611
Copy link
Contributor

@nikhil2611 nikhil2611 commented May 31, 2022

Signed-off-by: nikhil2611 [email protected]

Description

Added the settings screen to view and update the basic infra settings used in workstation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: nikhil2611 <[email protected]>
@nikhil2611 nikhil2611 requested review from a team as code owners May 31, 2022 06:33
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikhil2611 nikhil2611 marked this pull request as draft May 31, 2022 06:38
const fs = require('fs');

try {
fs.writeFileSync("/Users/ngupta/chef-repo/.chef/credentials", s);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename should be generic, something like '$HOME/.chef/credentials'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated, once the design is ready based on that this will be updated

const fs = require('fs');
window.data = {};

const fileData = fs.readFileSync('/Users/ngupta/chef-repo/.chef/credentials').toString('utf8');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants