-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to packages.chef.io #3920
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dishank Tiwari <[email protected]>
👷 Deploy Preview for chef-server processing.
|
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if these are correct.
@@ -134,7 +134,7 @@ This subcommand has the following options: | |||
|
|||
: Use to specify the location of a package. This option is not | |||
required when packages are downloaded from | |||
<https://packages.chef.io/>. | |||
<https://chefdownload-commercial.chef.io/>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah https://github.com/chef/chef-server/blob/main/src/chef-server-ctl/plugins/install.rb#L47 calls into https://github.com/chef/chef-server/blob/main/omnibus/files/server-ctl-cookbooks/infra-server/recipes/add_ons_wrapper.rb#L63 and that should pull from packages.chef.io https://github.com/chef/mixlib-install?tab=readme-ov-file#get-url-for-specific-platform-and-package-version so my understanding is that packages are still downloaded from packages.chef.io
@@ -266,8 +266,8 @@ first downloaded to a local directory, and then installed. | |||
**Use Downloads** | |||
|
|||
The `install` subcommand downloads packages from | |||
<https://packages.chef.io/> by default. For systems that are not behind | |||
a firewall (and have connectivity to <https://packages.chef.io/>), the | |||
<https://chefdownload-commercial.chef.io/> by default. For systems that are not behind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
@@ -1,5 +1,5 @@ | |||
The `install` subcommand downloads packages from <https://packages.chef.io> by default. | |||
For systems that are not behind a firewall (and have connectivity to <https://packages.chef.io>), these packages can be installed as described below. | |||
The `install` subcommand downloads packages from <https://chefdownload-commercial.chef.io> by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
Closing because these changes aren't correct. |
Quality Gate passedIssues Measures |
Description
[Please describe what this change achieves]
Issues Resolved
https://progresssoftware.atlassian.net/browse/CHEF-15020
Check List