convert to shell_out(), fixes #116 #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoriz
force-pushed
the
rmoriz/issue-116
branch
from
711a931 to
b6108ba
Compare
|
Heads up if you change this the minimum client release supported needs to get changed to 12.11 |
|
@tas50 Appreciate your feedback! I this a show-stopper, or should I just bump the version in |
|
Up to process really but if you wanna bump it make sure to do the metadata and the readme |
Signed-off-by: Roland Moriz <[email protected]>
rmoriz
force-pushed
the
rmoriz/issue-116
branch
from
b6108ba to
a8e277c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #116
shell_outfixes the PATH issue.