Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Data Bag Items must contain a Hash or Mash!" introduced in 1.3.1 #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justintime
Copy link

I really don't think this is the proper fix for the problem brought up in #20, but I can tell you these facts:

  • chef-vault 1.3.0 worked fine in our chefspec tests for our cookbooks
  • chef-vault 1.3.1 introduced the problem mentioned in the issue above
  • reverting back to 1.3.0 without changing anything else allowed chefspec to pass

I looked at the changes in helper.rb between releases, and came up with this hack which works in our case. I don't think this is the proper fix, rather I just wanted to point out something that worked so that someone more familiar with chef-vault cookbook, chef-vault, and chef could get a head start on finding the bug.

Fix for "Data Bag Items must contain a Hash or Mash!"
@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@chef-supermarket
Copy link

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@dwmarshall
Copy link

Error still occurs with 1.3.2

@tas50 tas50 removed the Signed CLA label Jan 5, 2017
@tas50
Copy link
Contributor

tas50 commented Jul 24, 2018

@justintime Any chance you can tell me if this is still an issue we need to address?

@tas50 tas50 added Triage: Needs Information Indicates an issue needs more information in order to work on it. and removed Status: Pending Contributor Response labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Needs Information Indicates an issue needs more information in order to work on it.
Development

Successfully merging this pull request may close these issues.

4 participants