This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Ensure initial admin password is set on first run #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change applies only to the debian-based family. After package install, grafana-server service is automatically started. In result, default "admin" password is assigned to "admin" user. Reference: http://docs.grafana.org/installation/configuration/#admin-password To setup initial password it is required to write it in grafana.ini before first service start. Currently, the only way to achieve this, is to block service autostart (dpkg_autostart resource) and let Chef handle everything - enable service and restart after grafana.ini is changed. This change should not be disruptive for any cookbook user. Signed-off-by: Szymon Szypulski <[email protected]>
szymonpk
force-pushed
the
set-initial-admin-password
branch
from
3e72d47 to
1d92163
Compare
iennae
reviewed
Jan 5, 2018
| @@ -32,5 +36,5 @@ | |||
| end | |||
|
|
|||
| service 'grafana-server' do | |||
| action [:enable, :start] | |||
| action :enable | |||
There was a problem hiding this comment.
This change looks like the service isn't started so would impact folks. Can you give more information about why the change here?
There was a problem hiding this comment.
With :start service was started before configuration recipe kicked-in. And admin-password was set to the default one. It should not be a problem because change to grafana.ini will induce restart..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies only to the debian-based family.
After package install, grafana-server service is automatically started.
In result, default "admin" password is assigned to "admin" user.
Reference: http://docs.grafana.org/installation/configuration/#admin-password
To setup initial password it is required to write it in grafana.ini
before first service start. Currently, the only way to achieve this, is
to block service autostart (dpkg_autostart resource) and let Chef
handle everything - enable service and restart after grafana.ini is
changed.
This change should not be disruptive for any cookbook user.