Skip to content

Commit

Permalink
Issue #345: update to CS 8.37
Browse files Browse the repository at this point in the history
  • Loading branch information
muhlba91 committed Nov 14, 2020
1 parent 703c4c5 commit 5e1e6b7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 10 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Compatibility matrix from checkstyle team:

Checkstyle Plugin|Sonar min|Sonar max|Checkstyle|Jdk
-----------------|---------|---------|----------|---
8.37|7.9 |7.9+|8.37|1.8
8.35|7.9 |7.9+|8.35|1.8
4.34|7.9 |7.9+|8.34|1.8
4.33|7.9 |7.9+|8.33|1.8
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.github.checkstyle</groupId>
<artifactId>checkstyle-sonar-plugin</artifactId>
<version>8.36-SNAPSHOT</version>
<version>8.37-SNAPSHOT</version>
<packaging>sonar-plugin</packaging>

<name>Checkstyle SonarQube Plugin</name>
Expand Down Expand Up @@ -93,7 +93,7 @@
</ciManagement>

<properties>
<checkstyle.version>8.36.1</checkstyle.version>
<checkstyle.version>8.37</checkstyle.version>
<sonar.version>7.9</sonar.version>
<sonar-java.version>6.0.0.20538</sonar-java.version>
<maven.checkstyle.plugin.version>3.1.1</maven.checkstyle.plugin.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void test() {
// such number should not change during checkstyle version upgrade
assertThat(duplicatedRuleWithTemplate).hasSize(174);
// all new Rules should fall in this group
assertThat(rulesWithDuplicateTemplate).hasSize(5);
assertThat(rulesWithDuplicateTemplate).hasSize(6);

for (RulesDefinition.Rule rule : rules) {
assertThat(rule.key()).isNotNull();
Expand Down
7 changes: 0 additions & 7 deletions wercker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@ box: maven:3.6.3-jdk-11

build:
steps:
- script:
name: install metadata-gen in local repo
code: |
git clone https://github.com/checkstyle/metadata-gen.git
cd metadata-gen
mvn install
cd ../
- script:
name: setup maven local repo
code: |
Expand Down

0 comments on commit 5e1e6b7

Please sign in to comment.