Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sevntu to target platform #684

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

Bananeweizen
Copy link
Collaborator

This adds the sevntu plugin to the target platform. That way launching a debug runtime from the IDE automatically includes sevntu. Have a checkstyle import check to avoid anyone referencing code from the sevntu plugin.

Be aware that this PR includes #681, because changes on the generated .target file are always conflicting. Therefore 681 should be merged first, and then this PR.

@rnveach
Copy link
Member

rnveach commented Apr 1, 2024

That way launching a debug runtime from the IDE automatically includes sevntu

Just confirming, this only includes sevntu for debugging, it will not include sevntu in the eclipse-cs release?

@Bananeweizen
Copy link
Collaborator Author

Just confirming, this only includes sevntu for debugging, it will not include sevntu in the eclipse-cs release?

Exactly. It would have to be included into the feature.xml to become part of eclipse-cs. And I added the checkstyle rule to avoid any accidental reference from eclipse-cs to sevntu code.

That is the most simple way of testing also the sevntu functionality.
Launching a debug runtime with all workspace and target platform plugins
enabled has the sevntu plugin automatically.
@Bananeweizen Bananeweizen merged commit eec9691 into checkstyle:master Apr 2, 2024
7 checks passed
@Bananeweizen Bananeweizen deleted the sevntu branch April 2, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants