Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZoomChat Enhancement #23

Closed
wants to merge 4 commits into from
Closed

ZoomChat Enhancement #23

wants to merge 4 commits into from

Conversation

Apipia
Copy link

@Apipia Apipia commented Jun 16, 2021

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added support for zoom chat. Since the Zoom "Incoming Webhook" app uses an authorization header, I created a separate condition for zoomchat to keep previous webhooks backwards compatible. Sending the body as a json created odd results in ZoomChat where text did not render. My implementation sends it as plain-text.

References

Issue #22

Testing

Tested changes with and without "auth" keyword in config file to ensure that it functioned without it.
Tested script without zoom chat to ensure it worked as it previously had

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@Apipia Apipia closed this by deleting the head repository Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant