Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tolerations #165

Closed
wants to merge 4 commits into from

Conversation

awalford16
Copy link

Add support for node tolerations through TOLERATIONS env variable, in the format of key=value:NoSchedule

❯ k get node aks-gpu4cpu-15439062-vmss00001o -o yaml | yq .spec.taints
- effect: NoSchedule
  key: sku
  value: gpu
❯ k get pods -o wide | grep image
kubernetes-image-puller-4vs98                                  3/3     Running     0               9m25s   10.244.12.8   aks-gpu4cpu-15439062-vmss00001o     <none>           <none>
kubernetes-image-puller-54wtr                                  3/3     Running     0               9m25s   10.244.8.8    aks-gpu4cpu-15439062-vmss00001m     <none>           <none>
kubernetes-image-puller-84t4d                                  3/3     Running     0               9m25s   10.244.7.8    aks-gpu4cpu-15439062-vmss00001l     <none>           <none>
❯ k get pod kubernetes-image-puller-4vs98 -o yaml | yq .spec.tolerations
- effect: NoSchedule
  key: sku
  operator: Equal
  value: gpu
- effect: NoExecute
  key: node.kubernetes.io/not-ready
  operator: Exists
- effect: NoExecute
  key: node.kubernetes.io/unreachable
  operator: Exists
- effect: NoSchedule
  key: node.kubernetes.io/disk-pressure
  operator: Exists
- effect: NoSchedule
  key: node.kubernetes.io/memory-pressure
  operator: Exists
- effect: NoSchedule
  key: node.kubernetes.io/pid-pressure
  operator: Exists
- effect: NoSchedule
  key: node.kubernetes.io/unschedulable
  operator: Exists

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Collaborator

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkwon17 could you please review

@ibuziuk
Copy link
Collaborator

ibuziuk commented Mar 5, 2024

Thank you for the contribution, but we consider merging #165 once the conflicts are resolved since it looks more configurable

@dkwon17
Copy link
Collaborator

dkwon17 commented Mar 6, 2024

Thank you @awalford16 , we decided to merge #162 because it allows configuring the operator field, as well as allowing omitting certain fields like key, effect etc.

@dkwon17 dkwon17 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants