Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add build command to devfile #2744

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

nickboldt
Copy link
Collaborator

@nickboldt nickboldt commented Sep 21, 2023

What does this PR do?

chore: add build command to devfile

Change-Id: I90831fdd3ab07af88eec79a270425f34b300fd3b
Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

followup to #2743
related to https://issues.redhat.com/browse/CRW-4855

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I90831fdd3ab07af88eec79a270425f34b300fd3b
Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt changed the title add build command to devfile chore: add build command to devfile Sep 21, 2023
…t npm too

Change-Id: Ib6b46e97bb528d94b960b31bc95d5c47146e9fdb
Signed-off-by: Nick Boldt <[email protected]>
@tolusha
Copy link
Collaborator

tolusha commented Sep 22, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@nickboldt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-chectl 951add3 link true /test v11-chectl
ci/prow/v12-chectl 951add3 link true /test v12-chectl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nickboldt nickboldt merged commit b10b26b into main Sep 22, 2023
@nickboldt nickboldt deleted the devfile-with-build-command branch September 22, 2023 18:48
@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1390: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1389: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants