Skip to content

Commit

Permalink
chore: fix: update to oclif v3 instead of archived/obsolete oclif-dev v1
Browse files Browse the repository at this point in the history
Change-Id: Ie5148a80ba50f1a125eebd6f10e2f099d276ee59
Signed-off-by: Nick Boldt <[email protected]>
  • Loading branch information
nickboldt committed Sep 21, 2023
1 parent cef220e commit 3535bf7
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/minikube-chectl-release-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
with:
node-version: 18.16.1
- name: Pack chectl binaries
run: yarn && npx oclif-dev pack --targets=linux-x64
run: yarn && npx oclif pack tarballs --no-xz --parallel --targets=linux-x64
- name: UnPack chectl binaries in $HOME/chectl
run: |
# Will unpack chectl binaries in $HOME/chectl
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ jobs:
- name: Build chectl
run: yarn
- name: Build README.md
run: yarn oclif-dev readme
run: yarn oclif readme
- name: Check README.md state
run: |
IFS=$'\n' read -d '' -r -a FILES_CHANGED_ARRAY < <( git ls-files -m ) || true
# check if readme it is up to date
if [[ " ${FILES_CHANGED_ARRAY[@]} " =~ "README.md" ]]; then
echo "[ERROR] README.md it is not up to date. Please run 'yarn oclif-dev readme' to update and commit the changes."
echo "[ERROR] README.md it is not up to date. Please run 'yarn oclif readme' to update and commit the changes."
exit 1
fi
license-validation:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
git tag ${{ steps.TAG_UTIL.outputs.gh_tag }}
TARGETS=linux-arm,linux-x64,linux-s390x,linux-ppc64le,darwin-x64,darwin-arm64,win32-x64,win32-x86
npx oclif-dev pack --targets=$TARGETS
npx oclif pack tarballs --no-xz --parallel --targets=$TARGETS
- name: Create Release and push artifacts
uses: softprops/action-gh-release@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
},
{
"label": "Update README.md",
"command": "yarn oclif-dev readme",
"command": "yarn oclif readme",
"type": "shell",
"args": [],
"problemMatcher": [
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ For packaging binaries, [oclif](https://github.com/oclif/dev-cli) is used. It ge
To start packaging, just run the `[Chectl] Package Binaries` command. It will run the following in the `/projects/chectl` directory:

```bash
yarn oclif-dev pack
yarn oclif pack tarballs --no-xz --parallel
```

> Note: you need to build your `chectl` before by `yarn` command, or install all node packages by running `npm install` in `/projects/chectl` directory.
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"uuid": "^9.0.0"
},
"devDependencies": {
"@oclif/dev-cli": "^1",
"@oclif": "^3",
"@oclif/test": "^2",
"@types/chai": "^4",
"@types/command-exists": "^1.2.0",
Expand Down Expand Up @@ -139,13 +139,13 @@
"e2e-minikube": "export PLATFORM=minikube && yarn jest ./test/e2e/e2e.test.ts --testRegex='/test/(e2e)/.*.test.ts'",
"e2e-openshift": "export PLATFORM=openshift && yarn jest ./test/e2e/e2e.test.ts --testRegex='/test/(e2e)/.*.test.ts'",
"gnirts-ci": "node .ci/obfuscate/gnirts.js",
"prepack": "yarn lint && rm -rf lib && rm -rf tsconfig.tsbuildinfo && tsc -b && oclif-dev manifest && oclif-dev readme && yarn gnirts-ci",
"pack-binaries": "oclif-dev pack",
"prepack": "yarn lint && rm -rf lib && rm -rf tsconfig.tsbuildinfo && tsc -b && oclif manifest && oclif readme && yarn gnirts-ci",
"pack-binaries": "oclif pack tarballs --no-xz --parallel",
"postpack": "rm -f oclif.manifest.json",
"format": "tsfmt -r --useTsfmt tsfmt.json",
"lint": "eslint --cache=true --no-error-on-unmatched-pattern=true '{src,tests}/**/*.ts'",
"lint:fix": "eslint --fix --cache=true --no-error-on-unmatched-pattern=true \"{src,tests}/**/*.{ts,tsx}\"",
"version": "oclif-dev readme && git add README.md",
"version": "oclif readme && git add README.md",
"watch": "tsc --watch"
},
"types": "lib/index.d.ts",
Expand Down

0 comments on commit 3535bf7

Please sign in to comment.