-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override the ssh-askpass.sh script from the git extension to respect the workspace ssh key #400
Conversation
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-400-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- git clone using ssh, like [email protected]:RomanNikitenko/web-nodejs-sample.git
- git pull
With PR changes I was able to do git operations using ssh without errors and VS Code didn't ask me passphrase
@musienko-maxim @SkorikSergey could you please review? |
I would like to postpone this PR because it is not actual with the current DWO. However I would like to keep the PR in case we switch the DWO logic to |
What does this PR do?
Override the
ssh-askpass.sh
script from thegit
extension to read the passphrase mounted to workspace by the ssh secret.What issues does this PR fix?
devfile/devworkspace-operator#1295
How to test this PR?
DISPLAY
environment variable. The env variable is needed to invoke the ssh askpass script flow. This variable will be added as permanent in the upcoming DWO pull request.Git: Pull
See: the command executes without asking the ssh passphrase.
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder