486: Scalar Multiply LQR bug #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
PrimePalaver
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
PrimePalaver
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Reviewable status:
davidabrahams
requested changes
Jul 17, 2019
There was a problem hiding this comment.
Reviewable status: davidabrahams must resolve 1 discussion (waiting on @billmwong)
src/plan/funnel.js, line 98 at r1 (raw file):
leftFunnelEdge = new Edge(ballLocation, leftPoints[startingIndex].clearancePoint); rightFunnelEdge = new Edge(ballLocation, rightPoints[startingIndex].clearancePoint); if (startingIndex + 1 >= path.length) break;
can we add a test case which produces this bug? (which fails without this fix?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486
This change is