-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Socket API support #16
Conversation
@DMBlakeley take a look when you get a chance - local udp API implementation! |
@chasenicholl will take a look. Nice work! Have the 4.0.0 version running on my MacBook and 3.0.3 version running on my Mac mini so I can easily compare between the two versions. |
Thanks @DMBlakeley! |
* Added Local UDP API support! Now you can choose to listen to your Weather Stations observations directly over your local network. No Station ID or API Token needed. Observations are broadcasted every 60 seconds. This leverages the `obs_st` message. See [documentation](https://weatherflow.github.io/Tempest/api/udp/v171/) for more information.
Hi @chasenicholl, I have dug into v4.0.0 comparing it to v3.0.3 as well as the Tempest App directly. I have a number of recommended changes to a number of files:
For the All the updated files can be found in my directory (https://github.com/DMBlakeley/homebridge-weatherflow-tempest). Now need to figure out how to push to you. |
- Fixed error in config.schema.json which was blocking display of occupancy sensor type. - Added note in README.md to indicate that `precip_accum_local_day` not available in local API.
Changes are in my files. |
Add description that states that `precip_accum_local_day` is not supported using Local API.
@DMBlakeley thank you for the thoughtful feedback. Please feel free to checkout this branch locally, commit your changes and push here for one more round of reviews before we publish the big update! edit* apologies I didn't realize I hadn't added you as an official collaborator yet. I just corrected that. You should now be able to directly contribute. Thank you again. |
Disable `precip_accum_local_day` Occupancy Sensor if using Local API.
Hi Chase,
Which do you prefer? |
@DMBlakeley great question. Lets have you create a branch from this branch. Make your changes. And open a new PR for me to review merging your changes back into this branch. Make sense? |
@chasenicholl, I think that creating a PR against the Let me give my updates one more review and I will submit the PR for your review and merging into this branch and then back into |
@chasenicholl, I submitted PR #17 against the Local Socket API branch last evening. Let me know if there are any issues with this approach. |
@DMBlakeley I've been running this branch locally now since I merged your PR without issues. How about yourself? |
@chasenicholl, I have also been running v4.0.0 without issues. Have found very good correlation between v4.0.0 and the Tempest app. My recommendation would be to release. |
[v4.0.0]
Added Local UDP API support! Now you can choose to listen to your Weather Stations observations directly over your local network. No Station ID or API Token needed. Observations are broadcasted every 60 seconds. This leverages the obs_st message. See documentation for more information.