Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nomodule attribute #151

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Oct 30, 2024

This PR adds support for the nomodule attribute in script tags.

Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Can you also add it to this list of boolean attributes please: https://github.com/chasefleming/elem-go/blob/main/elem.go#L36

@mgred
Copy link
Contributor Author

mgred commented Nov 2, 2024

Thanks for adding this! Can you also add it to this list of boolean attributes please: https://github.com/chasefleming/elem-go/blob/main/elem.go#L36

Hey, @chasefleming It's already in the commit

@chasefleming
Copy link
Owner

My bad, @mgred . Thanks again!

@chasefleming chasefleming merged commit e134535 into chasefleming:main Nov 5, 2024
1 check passed
@mgred mgred deleted the add-nomodule branch November 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants