Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Added rest of the CSS grid properties #15

Merged

Conversation

Paul-Annay
Copy link
Contributor

What changes does this PR introduce?

In this PR the styles.go file is updated by adding the grid-properties (mentioned below) following the MDN.

grid-auto-columns,
grid-auto-rows,
grid-column-gap,
grid-gap,
grid-row-gap,
grid-template-areas,
grid-template-columns,
grid-template-rows,

Fixes:

Issue #14

Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Looks great. I just left a couple notes on a few that were deprecated for different syntax.

styles/styles.go Outdated Show resolved Hide resolved
styles/styles.go Outdated Show resolved Hide resolved
styles/styles.go Outdated Show resolved Hide resolved
@Paul-Annay
Copy link
Contributor Author

Awesome, thank you! Looks great. I just left a couple notes on a few that were deprecated for different syntax.

@chasefleming thank you for your prompt review, I have made the suggested changes. Feel free to send more feedback if necessary.

Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Paul-Annay !

@chasefleming chasefleming merged commit 1282757 into chasefleming:main Oct 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants