Add isZoomingOrPanning method #823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
reviewed
Aug 22, 2024
| @@ -225,3 +225,8 @@ export function isZoomedOrPanned(chart) { | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| export function isZoomingOrPanning(chart) { | |||
There was a problem hiding this comment.
Shouldn't this be called IsPanningOrDragging?
There was a problem hiding this comment.
My thinking was, "zoom or pan" describes the plugin's two main pieces of functionality; its isZoomedOrPanned method therefore means, roughly, "has the plugin been activated"; so I called the new method isZoomingOrPanning to check "is the plugin currently being activated / manipulated."
I'm happy with isPanningOrDragging too - whatever makes the most sense for users of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to ensure that browser click events don't trigger if the user is zooming or panning (similar to how Chart.js prevents its own click events from triggering if the user is zooming or panning). Adding a new
isZoomingOrPanningmethod seems like the easiest solution.