Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial JFreeChart port of Time Profile #91

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chin123
Copy link
Contributor

@chin123 chin123 commented Jun 19, 2019

Done so far:

  • Main graph
  • Custom Tool Tip
  • Legend
  • Removed the options to analyze slope, iteration markers and hide tooltips, as they are not compatible with jfreechart

What could be improved:

  • Better colors (right now they are automatically assigned by JFreeChart)
  • Improve rendering performance in some way
  • Bring back slope analyzing, iteration markers and hiding tooltips

@chin123 chin123 requested a review from rbuch as a code owner June 19, 2019 20:11
@chin123
Copy link
Contributor Author

chin123 commented Jun 20, 2019

Unfortunately, it looks like JFreeChart is much slower than the custom renderer which is currently used in Time Profile. I'm not sure how to improve the performance of JFreeChart so that it can be as fast as the current renderer.

@chin123
Copy link
Contributor Author

chin123 commented Jun 26, 2019

After some profiling, it looks like most of the CPU time is spent on rendering the time profile swing window, which is most probably due to JFreeChart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants