Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test framework supports ensuring specific port is open #606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaw
Copy link

@jaw jaw commented Nov 21, 2024

The generic "waitforserver" has been renamed to
"ensureserverrunning".

This command now also takes an argument which denotes which environment variable to pick the port from.

This is needed as the ports are randomized by the test.

The generic "waitforserver" has been renamed to
"ensureserverrunning".

This command now also takes an argument which denotes
which environment variable to pick the port from.

This is needed as the ports are randomized by the test.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (b06b555) to head (0764890).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   51.96%   51.67%   -0.29%     
==========================================
  Files         157      159       +2     
  Lines       13454    13529      +75     
==========================================
  Hits         6991     6991              
- Misses       5891     5969      +78     
+ Partials      572      569       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant