Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cc bug #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed cc bug #5

wants to merge 2 commits into from

Conversation

lclem
Copy link

@lclem lclem commented Nov 17, 2019

fixed a bug which triggered a cc keypress from a non-cc midi note input

@charlieroberts
Copy link
Owner

I know this is an old request, but since another user referred to it... if you want to comment out the various printf statements in added in the pull request I will happily merge this.

@FirbyKirby
Copy link

FirbyKirby commented Sep 12, 2021

@lclem , would it be possible for you to remove the printf statements as @charlieroberts has suggested? If you are unable, I can try to take a stab at it. I'm no programmer, but removing the printf statements seems simple enough (I can make my own pull request with manually duplicated the changes Iclem made, minus the printf statements, but I don't want to take credit for that work.)

This little bug is preventing me from using midiStroke and it would be very nice to get it fixed. The application is otherwise working just fine in Big Sur after adding it to the accessibility whitelist. I haven't found an alternative for this relatively simple need that doesn't cost 10s of dollars (and apparently doesn't work well,) so I'm hoping we can get this project slightly updated to keep it useful.

For reference, a really useful use case for this is functionality is using pedals on a digital piano to turn pages in digital sheet music in an app. Or, in my less common use case, starting and stopping lessons in Playground (piano learning software that interfaces via midi to digital piano.) Using note on/off wouldn't be a viable workaround as I need the full keyboard for music, but rarely need all 3 pedals (was aiming to use the soft pedal for this functionality.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants