Skip to content

Commit

Permalink
fix review 5.22
Browse files Browse the repository at this point in the history
TODO add a test for collision with a generated getter
  • Loading branch information
charles-cooper committed Jun 22, 2023
1 parent cccfefc commit 16275bc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions vyper/semantics/analysis/module.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def __init__(
err_list.raise_if_not_empty()

# generate an `InterfaceT` from the top-level node - used for building the ABI
# note: also validates unique method ids
interface = InterfaceT.from_ast(module_node)
module_node._metadata["type"] = interface
self.interface = interface # this is useful downstream
Expand All @@ -105,8 +106,6 @@ def __init__(
# internal functions are intentionally included in this check, to prevent breaking
# changes in in case of a future change to their calling convention
self_members = namespace["self"].typ.members
functions = [i for i in self_members.values() if isinstance(i, ContractFunctionT)]
validate_unique_method_ids(functions)

# get list of internal function calls made by each function
function_defs = self.ast.get_children(vy_ast.FunctionDef)
Expand Down

0 comments on commit 16275bc

Please sign in to comment.