Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade starters to App Router #720

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Upgrade starters to App Router #720

merged 7 commits into from
Apr 24, 2024

Conversation

JohnAlbin
Copy link
Collaborator

@JohnAlbin JohnAlbin commented Mar 11, 2024

This pull request is for:

  • starters/basic-starter
  • starters/graphql-starter

GitHub Issue: #601

Describe your changes

Adds a pages-starter that uses the Pages Router. Upgrades basic-starter and graphql-starter to use App Router.

This PR depends on #716 and #719 and should be reviewed (and rebased) after those PRs are merged. Those PRs have been merged and this branch has been rebased onto main.

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 1:29pm

@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from d01e59c to b1742dc Compare March 11, 2024 18:58
@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from b1742dc to 8472f77 Compare April 18, 2024 17:40
@JohnAlbin JohnAlbin marked this pull request as ready for review April 18, 2024 17:43
@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from 8472f77 to 56d3209 Compare April 20, 2024 02:08
@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from 56d3209 to 8326563 Compare April 22, 2024 15:41
@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from f8cd4d1 to 46d8361 Compare April 22, 2024 16:41
@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch 3 times, most recently from 1ef435b to f4348e0 Compare April 23, 2024 12:43
@JohnAlbin
Copy link
Collaborator Author

This PR also fixes #749

@JohnAlbin JohnAlbin force-pushed the 601-upgrade-starters branch from f4348e0 to 1815ac0 Compare April 23, 2024 13:29
@JohnAlbin JohnAlbin merged commit 41bdd55 into main Apr 24, 2024
11 checks passed
@JohnAlbin JohnAlbin deleted the 601-upgrade-starters branch April 24, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants