Add support for atomic min and max #25900
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for atomic min and max. While there is an expectation that these signatures can be stable, this PR adds them as unstable for now.
See issue #22867 which requests this functionality.
What do other languages do here?
atomic_fetch_min
/atomic_fetch_max
(and also_explicit
variants of these to allow providing the memory order).fetch_min
andfetch_max
(see e.g. https://doc.rust-lang.org/std/sync/atomic/struct.AtomicU32.html#method.fetch_max)Future Work: